Repository navigation
Feature A / #307 merge-flow: qualify exact-group reports with synthetic JUnit - #1269
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scope
Feature A (#1214), #307 merge-flow row. Test tier T1. Originally stacked on #1246 at
117b10bb. GitHub retargeted this PR to main after #1246 merged asd1a7e7cf. The branch merge05965df4resolves the actual report-fixture and queue-module conflicts. The resulting tree matches current main plus the original test patch byte for byte.The hosted shadow fixture supplies a real compressed JUnit ZIP with one passing case and one failing case. It requires the journal to retain the verified digest and check IDs for the exact removed group. Two PRs in the same group share a download, but the other PR cannot inherit the artifact after its check-suite identity changes. The mocked GitHub command accepts only GraphQL queries and Actions GETs and records any attempted write. Existing timing, digest-mismatch and shared-byte-budget controls still run.
The archive builder is a dev dependency. This slice replaces opaque test bytes and changes no production Rust, decoder, author-notice adapter, review policy, or workflow. The decoder and notice follow-on remain staged. No live notifications or retries.
Verification
Formatting and diff whitespace passed. On the original stacked head
29333db9, the exact fixture passed in required checks and in the x86_64 and ARM64 lanes, with 4,796 tests passing on each lane. Both mandatory sandbox partitions and the inventory gate passed. Codex code review reported no findings on that head.The new head
05965df4has its own required checks and hosted lanes. Both required sandbox partitions, the inventory gate, and CodeQL passed. The exact report fixture passed again on both architectures, with 4,860/4,860 tests in each hosted lane. Exact-head Codex review reported no findings. The normal queue started merge-group checks onb72f5fc1.Landed at
b72f5fc189a407d918a2426375f4b5ebcc39d40c. Both exact merge-group sandbox partitions and the inventory gate passed. The decoder follows in #1277.